Add cache_pygates feature to accelerate crate.#13183
Merged
Merged
Conversation
Co-authored-by: Elena Peña-Tapia <57907331+ElePT@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Collaborator
|
One or more of the following people are relevant to this code:
|
raynelfss
added
the
Changelog: None
mtreinish
approved these changes
Sep 18, 2024
mtreinish
left a comment
mtreinish
left a comment
Member
There was a problem hiding this comment.
LGTM this is a straightforward addition and one I've done in some local code that isn't quite ready for a PR so glad to spin it out here even if nothing is using it yet.
Pull Request Test Coverage Report for Build 10927852001Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The following commits add the
cache_pygatesfeature from thecircuitcrate intoaccelerate.Details and comments
Since we added rust native methods to add operations into the
DAGCircuit(thanks in part to #13143), we make use of thecache_pygatefeature which is only available in thecircuitcrate. A couple of transpiler passes which require building instances ofDAGCircuitfrom Rust entirely (mainly #13141, and #13137) are using these functions, they need to respect the bounds this feature specifies or else they would not compile.A couple of teammates have already implemented this flag as part of their PRs but, to prevent a future merge conflict debacle, I decided to put it in this PR. These commits add the feature to
accelerateso that people don't have to worry about that in the future.